Skip to content

Conversation

@ermalkaleci
Copy link
Contributor

No description provided.

@ermalkaleci ermalkaleci requested a review from xlc February 27, 2022 20:10
@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #1925 (26a5c8e) into master (94b5426) will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
- Coverage   86.02%   85.77%   -0.26%     
==========================================
  Files          89       87       -2     
  Lines       19226    18336     -890     
==========================================
- Hits        16540    15727     -813     
+ Misses       2686     2609      -77     
Impacted Files Coverage Δ
modules/currencies/src/tests.rs
modules/currencies/src/lib.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b5426...26a5c8e. Read the comment docs.

xlc
xlc previously approved these changes Feb 27, 2022
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not checked in CI?

@ermalkaleci
Copy link
Contributor Author

Is this not checked in CI?

Yeah we don't run it. Will include it on benchmark tests

@ermalkaleci ermalkaleci merged commit 0422862 into master Feb 27, 2022
@ermalkaleci ermalkaleci deleted the fix_evm_bench branch February 27, 2022 22:54
syan095 pushed a commit that referenced this pull request Mar 8, 2022
…count

* origin/master: (21 commits)
  udpate predeploy and disable NFT precompile for karura & acala (#1942)
  remove old migrations (#1937)
  Optimized calculations t avoid error caused by division missing (#1935)
  Statemine integration test (#1712)
  switch to london (#1932)
  fix clap annotation (#1933)
  fix package name (#1928)
  type cleanup (#1931)
  bump version (#1930)
  V0.9.17 (#1924)
  update precompile set (#1929)
  bump version (#1926)
  use internal release for dev release
  fix evm-bench access_list (#1925)
  add missing precompiles and fixes (#1923)
  remove legacy trader location (#1920)
  cdp enhancement (#1886)
  add new call to execute completely fast match redeem (#1922)
  Change StorageDepositPerByte (#1919)
  add ACA to CollateralCurrencyIds (#1918)
  ...

# Conflicts:
#	Cargo.lock
#	orml
#	runtime/integration-tests/src/setup.rs
#	runtime/integration-tests/src/stable_asset.rs
#	runtime/mandala/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants